StackAggregator - several fixes #3210
Conversation
|
@M-i-k-e-l I was wondering if there's a simpler way, like moving the 'backgroundColor: 'transparent' to the Animated.View and the contentContainerStyle to the Card's style. What do you think? |
It causes another bug when adding a card. Marking with v8 |
Did you investigate the bug created when adding a card? Is it a complex fix? |
If you mean the bug with the shadows then I've committed it already (sadly it did not work well in master). |
Not what I meant. The shadow bug is on master. With my suggested fix there's a new bug where the cards disappear on iOS. I meant if you investigated this new one? Maybe it's a small fix? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@M-i-k-e-l Are you rebasing it to the V8 branch? |
@Inbal-Tish not sure yet (might add a commit to v8 or something), why? |
|
Cherry-picked into v8 |
* Upgrade to react native 0.76.9 Some errors in native code that I did not want to commit fixes just yet docuilib has issues (hopefully will be solved in 0.77.2 * RN77 upgrade + new arch Android runs (still need to fix native) | iOS red screen | docuilib still has errors * Remove TextInputDelKeyHandlerPackage (Android) * KeyboardAccessoryView on Android - fix crash (one bug left) Pressing on dismiss (x) only fully works the second time * Pressing on dismiss (x) only fully works the second time - a very complex fix * Remove unused code * HighlighterViewManager - fix (use new API) * Fix gesture handler changed style * Fix images (unrelated) * Fix PanViewScreen (unrelated) * Fix dragging in SortableList and SortableGridList * Update navigation * Change iOS back to Objective-C * Fix screen - border color * Revert to older reanimated and gesture-handler versions * Drawer - fix animation flickering * Remove comment * StackAggregator - several fixes - see #3210 * Drawer - fix color not being shown with multiple buttons (RectButton bug) * Fix * Downgrading reanimated and gesture handler * Fix * Fix iOS (setimmediate) * remove UIManager.setLayoutAnimationEnabledExperimental * Update RNN * Fix snapshot * Fix TS * Fix TS * Fix snapshot * Native lib reorder and fix ios (#3750) * Native lib - reorganize components in folders for convenience + bump version to 5.0.0 * pointing to index * revert naming change * fix api files * rename HighlighterOverlay web * Moving sub components to the parent * fix api file and move KeyboardUtils outside folder * Revert "fix api file and move KeyboardUtils outside folder" This reverts commit ff64327. * fix api json * fix folder name to match component name * remove specs * fix highligther view native registration * fix for SafeAreaSpacerView * fix types * fix for KeyboardTrackingView * trying to fix failed CI build * SafeAreaSpacesView - moving to react implementation using native SafeAreaManager * manager changes * fix safe area * fix SafeAreaSpacerView again * removing logs * Fix highlightViewTag type * Fix TS error * Typescript fixes \ revert * Revert --------- Co-authored-by: Miki Leib <[email protected]> Co-authored-by: M-i-k-e-l <[email protected]> * KeyboardAwareBase - fix error * Fix menu - "native" tag should show all (and only) native components * Update uilib-native to snapshot * Fix tests * Update uilib-native to snapshot * Fix TS error and web type * Change from codegenNativeComponent to requireNativeComponent in order to fix error after transpilation (#3768) * Change from codegenNativeComponent to requireNativeComponent * Update snapshot * Revert, move to specs and publish the typescript vesion (#3769) * Another try * Do not transpile specs * Another one * Update snapshot * SafeAreaSpacerView - fix race condition and a small refactor (#3770) * SafeAreaSpacerView - fix race condition and a small refactor * Update snapshot * Remove extra backgroundColor --------- Co-authored-by: Inbal Tish <[email protected]> Co-authored-by: Inbal Tish <[email protected]>
Description
Strictly speaking this is a breaking change (see change log notes), let me know what you think.
Although the previous code for the index comparison seemed correct, it did not work correctly on Android, the new logic works on both platforms (except on an edge case were the user is mixing controlled and uncontrolled usage).
For visibility I'll add the bug reproduction steps:
StackAggregatorScreen.Open Stackbutton.Show lessbutton.Close Stackbutton.Result - the edges of the cards "become straight" (this is actually the scale animation failing), I was not able to fix this and it seemed too small to invest more time into.
Changelog
🚫 StackAggregator - fix card being transparent on Android - BREAKING CHANGE - Cards'
backgroundColorshould now be passed via thebackgroundColorprop and not via thecontentContainerStylepropStackAggregator -
onCollapseChangedwill now be called after the animation has ended (as was intended)Additional info
Ticket 4186